Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Changed histogram binning logic" #3922

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Conversation

jessemapel
Copy link
Contributor

Reverts #3918

This is being reverted because it caused significant change in the app test outputs and more time it needed to check that it did not break anything. When, all of the changes are signed off on, it can be merged back in.

@jessemapel
Copy link
Contributor Author

Here are the failures:

The following tests FAILED:
     45 - isis3_unit_test_Cube (Failed)
     74 - isis3_unit_test_GaussianStretch (Failed)
     88 - isis3_unit_test_Histogram (Failed)
    203 - isis3_unit_test_ProgramLauncher (Failed)
    273 - isis3_unit_test_Stretch (Failed)
Errors while running CTest

The following tests FAILED:
    464 - decorstretch_app_test_default (Failed)
    555 - gaussstretch_app_test_default (Failed)
    585 - hist_app_test_default (Failed)
    586 - histeq_app_test_test (Failed)
    587 - histmatch_app_test_cdf (Failed)
    588 - histmatch_app_test_mode (Failed)
    596 - isis2fits_app_test_8bit (Failed)
    600 - isis2fits_app_test_multiBand (Failed)
    602 - isis2fits_app_test_signed16 (Failed)
    610 - isis2pds_app_test_linear (Failed)
    619 - isis2raw_app_test_8bit (Failed)
    622 - isis2raw_app_test_default (Failed)
    623 - isis2raw_app_test_defaultBIL (Failed)
    624 - isis2raw_app_test_defaultBIP (Failed)
    628 - isis2raw_app_test_multiBand (Failed)
    629 - isis2raw_app_test_multiBandBIL (Failed)
    634 - isis2raw_app_test_signed16 (Failed)
    636 - isis2raw_app_test_signed16BIP (Failed)
    637 - isis2raw_app_test_u16bit (Failed)
    643 - isis2std_app_test_jpeg2000 (Failed)
    645 - isis2std_app_test_tiff (Failed)
    768 - percent_app_test_case01_99 (Failed)
    769 - percent_app_test_case02_50 (Failed)
    770 - percent_app_test_case03_.1 (Failed)
    771 - percent_app_test_case04_mult (Failed)
    772 - phocube_app_test_allbands (Failed)
    829 - rgb2hsv_app_test_auto (Failed)
    897 - stats_app_test_default (Failed)
    898 - stats_app_test_format (Failed)
    955 - cnethist_app_test_case01 (Failed)
    996 - findfeatures_app_test_controlnet (Failed)
    997 - findfeatures_app_test_debug (Failed)
    999 - findfeatures_app_test_geom (Failed)
    1001 - findfeatures_app_test_messenger (Failed)
    1002 - findfeatures_app_test_multialgo (Failed)
    1003 - findfeatures_app_test_multialgofilter (Failed)
    1081 - apollopanstitcher_app_test_default (Failed)
    1288 - mdis2pds_app_test_minMaxPercent (Failed)
    1369 - hideal2pds_app_test_croppedAlphaCube (Failed)
    1390 - hijitter_app_test_default (Failed)
    1391 - hijitter_app_test_withCrop (Failed)
    1394 - hinoise_app_test_binningIsOne (Failed)
    1395 - hinoise_app_test_binningNotOne (Failed)
    1399 - hirdrgen_app_test_red (Failed)
    1400 - hirdrgen_app_test_red2 (Failed)
Errors while running CTest

The following tests FAILED:
    1469 - osirisrex_module_test_mapcam (Failed)
Errors while running CTest

The following tests FAILED:
    1613 - ThreeImageNetwork.FunctionalTestFindImageOverlapsNoOverlap (Child aborted)
    1960 - stats_MockHist.TestStats (Failed)
Errors while running CTest

Many of these are actually not failures and just differences in how we compute histogram stretches due to the bug in the histogram bin computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants