Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI helper to hist for minimum and maximum. Fixes #3880 #3999

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Sep 4, 2020

…N values are of the specified band of the cube

Add a GUI helper to hist that calculates the minimum and maximum DN of the first band of a cube (Cube Attributes are used), and populates the parameters with the respective values.

Description

Related Issue

#3880

Motivation and Context

Help the user find a good min/max without having to run stats on the cube before running hist

How Has This Been Tested?

This is a GUI feature. Runs were made with several cubes, and the GUI was changed to the expected state.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • [ X I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the AUTHORS.rst document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

…N values are of the specified band of the cube
Copy link
Contributor

@krlberry krlberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@krlberry
Copy link
Contributor

krlberry commented Sep 4, 2020

Actually, could you add a note about the change to the new changelog? I forgot about this earlier.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected behavior for multi-band cubes? This just checks the first band.

isis/src/base/apps/hist/main.cpp Show resolved Hide resolved
@scsides
Copy link
Contributor Author

scsides commented Sep 8, 2020

@jessemapel - The hist program only works on one band. If more exist or are specified in an input attribute, the first is used and all others are ignored. I'm not sure what the use case would be for a single histogram with data from multiple bands would be. It could output multiple hists (one for each band), but that's not the way it was written and it would have to allow a different min/max/nbins for each band (a hyperspectral cube could be difficult). The Gui Helper follows the way the current app works.

@jessemapel jessemapel merged commit 3aaa607 into DOI-USGS:dev Sep 8, 2020
@jessemapel jessemapel mentioned this pull request Sep 8, 2020
13 tasks
@scsides scsides deleted the histgears branch March 8, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants