Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Hi2isis MRO:ADC_TIMING_SETTING label conversion issue #4290 and Converted Hi2isis App and Tests #4362

Merged
merged 4 commits into from
Mar 17, 2021

Conversation

amystamile-usgs
Copy link
Contributor

Description

Fixed label conversion issue with MRO:ADC_TIMING_SETTING by updating the MroHiRiseInstrument.trn input key from "MRO:ADC_TIMING_SETTING" to "MRO:ADC_TIMING_SETTINGS". I also went through the label inputs and updated Spider Leg Temperatures labels to reflect the EDR labels (they were also reverting to -9999). Converted hi2isis App and add 3 gtests.

Related Issue

Fixes #4290

Motivation and Context

Updated instrument trn file to correctly convert label values from EDR file, specifically for MRO_ADC_TIMING_SETTING label input.

How Has This Been Tested?

Tested with 3 gtests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs
Copy link
Contributor Author

I had issues with cropping the test images. Therefore this PR includes the original test images. Not sure if the files are too large or okay as is to push to dev.

Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a change log entry

isis/src/mro/apps/hi2isis/MroHiriseInstrument.trn Outdated Show resolved Hide resolved
isis/src/mro/apps/hi2isis/MroHiriseInstrument.trn Outdated Show resolved Hide resolved
@amystamile-usgs
Copy link
Contributor Author

This should have a change log entry

Added a change log entry.

@amystamile-usgs amystamile-usgs requested a review from scsides March 16, 2021 18:24
@Kelvinrr
Copy link
Collaborator

@amystamile-usgs I think ~5mb is acceptable, especially considering HiRise sizes, if we have no other choice. I generally trust that this is probably the best we can do.

One thing I am wondering is that we need a better way to organize new test data in a way that isn't app specific (i.e. group images based on mission). Not something to address here, especially since these dont seem reusable, but something to consider on apps that use cubes.

@amystamile-usgs amystamile-usgs dismissed scsides’s stale review March 17, 2021 14:47

Requested changes have been made.

@scsides scsides merged commit a15b0c7 into DOI-USGS:dev Mar 17, 2021
@amystamile-usgs amystamile-usgs deleted the hi2isis branch March 22, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hi2isis does not properly convert MRO:ADC_TIMING_SETTINGS label from .IMG to .cub file
3 participants