Fix caminfo uselabel SegFault #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpaquette
requested changes
Apr 16, 2021
scsides
previously requested changes
Apr 16, 2021
jessemapel
dismissed
scsides’s stale review
Review is being taken over by @jessemapel
jessemapel
approved these changes
Apr 22, 2021
acpaquette
approved these changes
Apr 22, 2021
Kelvinrr
pushed a commit
to Kelvinrr/ISIS3
that referenced
this pull request
Jun 10, 2021
* conditionally reopen cube to prevent segfault * relocate cube close
Kelvinrr
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Change measure log name to be case-insensitive (#4441) * Lrowac2pds App and Test Conversion (#4429) * lrowac2pds app conversion * Lrowac2pds App and Test Conversion * Set global variables to static to prevent test failures * Gui Parameters now right aligned (#4507) * Findgaps gtests (#4422) * first few test cases, needs work * two working tests * add test for correlation tolerance * improve test data creation code * updated mapcam makefile (#4498) * merge conflict with 561e21e in changelog * improve grid extend test case (#4506) * fix sample_bits pvl output (#4500) * map2map conversion (#4435) * added code for two tests * test modifications * changed crop input and ouput function * fixed last two tests * added more tests * converted map2map * added conversion code for map2map * bring crop tests up to date with dev * added modifications to map2map and tests * final changes for map2map tests * Converted app and default test * Converted tests * Added histograms to tests. * Rename FunctionalTestsMap2Map.cpp to FunctionalTestsMap2map.cpp Co-authored-by: Amy Stamile <astamile@contractor.usgs.gov> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> * thm2isis now uses out attrs and converted to func (#4504) * thm2isis now uses out attrs and converted to func * removed commented code that manually set pixel type * added gtests * better params * IR test added * reordered things * cropped images * cropped image for outattr tests too * added missing changelog lines * Fix caminfo uselabel SegFault (#4402) * conditionally reopen cube to prevent segfault * relocate cube close * version ticks * change log merge conflict * added 5.0.1 bugfixes under a 5.0.1 header in CHANGELOG * removed unreleased portion of the changelog Co-authored-by: Jesse Mapel <jmapel@usgs.gov> Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Tim Giroux <62255438+tgiroux@users.noreply.github.com> Co-authored-by: robotprogrammer22 <46390033+robotprogrammer22@users.noreply.github.com> Co-authored-by: Amy Stamile <astamile@contractor.usgs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In caminfo there is a call to BandGeometry::collect that closes the input cube object if uselabel=yes. The cube needs to remain open for a few other tasks, so this was causing a segmentation fault. To fix this, I added a few lines after the BandGeometry::collect call that open the cube back up if uselabel=yes.
Related Issue
#4401
Motivation and Context
This bug was found in the release candidate due at end of month.
How Has This Been Tested?
All caminfo gtests are passing. Both sample caminfo calls given in #4401 run correctly.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: