-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for PSA compliant labels for TGO #4631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clean! Glad this came through from the CaSSIS team
As discussed in standup, this is being labeled as a bug fix in order to get the changes quickly pushed through for the CaSSIS team. In this case, the bug is that tgocassis2isis wasn't properly handling PSA labels. |
* Updated translation files to support PSA compliant labels * Added logic to support PSA labels * Test data for PSA labels * Added a test for PSA labels Co-authored-by: Austin Sanders <arsanders@ugs.gov>
* Updated translation files to support PSA compliant labels * Added logic to support PSA labels * Test data for PSA labels * Added a test for PSA labels Co-authored-by: Austin Sanders <arsanders@ugs.gov>
I am having problems using tgocassis2isis to import PSA CaSSIS data: tgocassis2isis from=cas_cal_sc_20181009T151049-20181009T151053-3916-40-PAN-276456777-39-0.xml to=test.cub Was this update included in the new ISIS version (6.0.0), or perhaps it's a different issue? |
This is going out in 7.0, see the changelog. You can install the release candidate or wait for the full release coming in 2 weeks. |
I am also having problems using tgocassis2isis to import PSA CaSSIS data: tgocassis2isis from=cas_raw_sc_2023074T223427-2023074T223431-25038-37-NIR-1125020420-29-2.xml to=123.cub I want to know how to reslove this issue |
Adds support for PSA compliant labels for CaSSiS
Description
Adds two additional translation files (suffixed with _PSA) in order to support new, PSA compliant labels for CaSSiS. Adds logic to tgocassis2isis to choose the appropriate translation file in order to support both new and old label formats.
Related Issue
Closes #4567
Motivation and Context
The CaSSiS team is unable to ingest images that conform to a new label specification.
How Has This Been Tested?
Existing tests that were passing still pass, adds a new test with PSA label.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: