Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for PSA compliant labels for TGO #4631

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

AustinSanders
Copy link
Contributor

Adds support for PSA compliant labels for CaSSiS

Description

Adds two additional translation files (suffixed with _PSA) in order to support new, PSA compliant labels for CaSSiS. Adds logic to tgocassis2isis to choose the appropriate translation file in order to support both new and old label formats.

Related Issue

Closes #4567

Motivation and Context

The CaSSiS team is unable to ingest images that conform to a new label specification.

How Has This Been Tested?

Existing tests that were passing still pass, adds a new test with PSA label.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clean! Glad this came through from the CaSSIS team

@AustinSanders AustinSanders added the bug Something isn't working label Sep 13, 2021
@AustinSanders
Copy link
Contributor Author

As discussed in standup, this is being labeled as a bug fix in order to get the changes quickly pushed through for the CaSSIS team. In this case, the bug is that tgocassis2isis wasn't properly handling PSA labels.

@AustinSanders AustinSanders merged commit 454a3ba into DOI-USGS:dev Sep 13, 2021
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 8, 2021
* Updated translation files to support PSA compliant labels

* Added logic to support PSA labels

* Test data for PSA labels

* Added a test for PSA labels

Co-authored-by: Austin Sanders <arsanders@ugs.gov>
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 15, 2021
* Updated translation files to support PSA compliant labels

* Added logic to support PSA labels

* Test data for PSA labels

* Added a test for PSA labels

Co-authored-by: Austin Sanders <arsanders@ugs.gov>
@0dvaz0
Copy link

0dvaz0 commented May 5, 2022

I am having problems using tgocassis2isis to import PSA CaSSIS data:

tgocassis2isis from=cas_cal_sc_20181009T151049-20181009T151053-3916-40-PAN-276456777-39-0.xml to=test.cub
USER ERROR Given file [cas_cal_sc_20181009T151049-20181009T151053-3916-40-PAN-276456777-39-0.xml] does not appear to be a valid TGO CaSSIS label.
ERROR Failed to translate output value for [ObservationId].
ERROR Failed traversing input position. [InputPosition] element does not have a child element named [Alias_List].

Was this update included in the new ISIS version (6.0.0), or perhaps it's a different issue?

@jessemapel
Copy link
Contributor

This is going out in 7.0, see the changelog. You can install the release candidate or wait for the full release coming in 2 weeks.

@wang-github-240118
Copy link

I am also having problems using tgocassis2isis to import PSA CaSSIS data:

tgocassis2isis from=cas_raw_sc_2023074T223427-2023074T223431-25038-37-NIR-1125020420-29-2.xml to=123.cub
USER ERROR Given file [cas_raw_sc_2023074T223427-2023074T223431-25038-37-NIR-1125020420-29-2.xml] does not appear to be a valid TGO CaSSIS label.
ERROR Failed to translate output value for [CoreSamples].
ERROR Failed traversing input position. [InputPosition] element does not have a child element named [Array_3D_Image].

I want to know how to reslove this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add / edit TGO CaSSiS translation files to support PSA compliant labels
5 participants