Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phocube add all bands Closes #3877 #4689

Merged
merged 6 commits into from
Jan 7, 2022
Merged

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Nov 15, 2021

New option to phocube to transfer all the input bands to the output file.

Description

The phocube program is now able to transfer all of the input bands to the output cube using the parameter "ALLDNS". Previously it required a single band cube as input and the "DNS" parameter would cause the first output band to be the DNs from the input cube.

Related Issue

#3877

Motivation and Context

User requested option

How Has This Been Tested?

Hand tests were run and a gtest was created.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good. Needs a changelog entry and the test could be more robust

isis/tests/FunctionalTestsPhocube.cpp Outdated Show resolved Hide resolved
isis/tests/FunctionalTestsPhocube.cpp Outdated Show resolved Hide resolved
@scsides scsides changed the title Phocubedns Closes #3877 Phocube add all bands Closes #3877 Jan 6, 2022
Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@jessemapel jessemapel merged commit f3bc19d into DOI-USGS:dev Jan 7, 2022
@scsides scsides deleted the phocubedns branch March 8, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants