Exclude ignored measures in cnetcheck #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
reviewed
Feb 10, 2022
Comment on lines
+639
to
+643
| if (ignore) { | ||
| measures = cnet.GetValidMeasuresInCube(serialNumber); | ||
| } else { | ||
| measures = cnet.GetMeasuresInCube(serialNumber); | ||
| } |
There was a problem hiding this comment.
Should we also ignore the point if all measures are ignored? That is, can all the measures be set to ignored but not the point? If so, in that case also ignore the point automatically? Or does cnetcheck already report points with no measures?
jessemapel
reviewed
Feb 10, 2022
| m2->SetAprioriLine(999); | ||
| m2->SetAprioriSample(999); | ||
| m2->SetCamera(cube2->camera()); | ||
| m2->SetCubeSerialNumber(cube2Serial); |
There was a problem hiding this comment.
I would also set these measures to ignored and look for 0 no-lat/lon cubes. I don't think that the third measure changes the cnetcheck output.
|
Needs a changelog entry |
… cnetcheck_ignored_measures
… cnetcheck_ignored_measures
jessemapel
approved these changes
Mar 2, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Modified noLatLon logic to exclude ignored measures * Added test for ignored measures * Added entry for cnetcheck ignored points * Added test for ignored point, fixed test for ignored measures
AustinSanders
added a commit
that referenced
this pull request
Mar 2, 2022
* Modified noLatLon logic to exclude ignored measures * Added test for ignored measures * Added entry for cnetcheck ignored points * Added test for ignored point, fixed test for ignored measures Co-authored-by: AustinSanders <austinsanders1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'ignore' flag was previously being used only to exclude ignored points, not ignored measures. This PR addresses this by excluding ignored measures.
Description
Makes use of the "GetValidMeasuresInCube" function to exclude ignored measures when the "ignore" flag is set.
Related Issue
Closes #4649
Motivation and Context
Including ignored measures results in false positives.
How Has This Been Tested?
Wrote a new test that adds an ignored control measure.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: