Changed SRC camera and serial number to use start time instead of sta… #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft until CI passes |
jessemapel
reviewed
Apr 16, 2022
|
It should affect the tests. That's why I put it into draft mode. I've been debating the camera version too. This is a breaking change, so yes it should be. I'll add that unless I see objections. |
This was referenced May 3, 2022
ladoramkershner
previously approved these changes
May 10, 2022
jessemapel
reviewed
May 11, 2022
|
This change required a change to the serial number for images from the SRC camera. Any existing control networks will need to be fixed. This seems like a breaking change. |
|
We should go with @jessemapel suggestion to remain consistent. |
ladoramkershner
approved these changes
May 13, 2022
Kelvinrr
pushed a commit
to gsn9/ISIS3
that referenced
this pull request
Jul 18, 2022
DOI-USGS#4910) * Changed SRC camera and serial number to use start time instead of start clock count * Change log entry * Tick the camera version to 2 * Update unittest * Update MexHrscSrcCamera.cpp * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed HRSC camera and serial number to use start time instead of start clock count
Description
The HRSC SCR framing camera often takes a series of images a few seconds apart. In some instances the start clock count is identical for all of the images. This was causing the SPICE attached in spiceinit to be inaccurate, and the serial
number for each of the images in the series was also identical making it impossible to use the serial numbers in the control software.
Related Issue
$4803
Motivation and Context
#4803
How Has This Been Tested?
All tests are awaiting a clean run of CI
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: