CNetCombinePt: only log merged points #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaura
reviewed
Jul 7, 2022
jessemapel
approved these changes
Jul 8, 2022
|
Once CI is clean, this can go in |
Kelvinrr
pushed a commit
to gsn9/ISIS3
that referenced
this pull request
Jul 18, 2022
* Adjusted logging functionality such that only merged points are present in log * Updated changelog * Added link to github issue * Edited logging test to include number of logged points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusted logging functionality such that only merged points are included
Related Issue
#4973
Motivation and Context
CNetCombinePt currently includes all points in the log, but it should only include merged points.
How Has This Been Tested?
ctest -VV -R "Cnetcombinept" all tests pass.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: