downloadIsisData Script fixes #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaura
reviewed
Aug 8, 2022
|
@jlaura Is this good to go now? |
|
This has issues that are fixed in #5032. We could merge this and then ask @foobarbecue to rebase and then merge that. Or we could incorporate this changes into this PR and close #5032. I think I'd prefer to merge this, have #5032 rebase, and then merge that PR so that we have a record of the contributions. |
jlaura
approved these changes
Aug 17, 2022
|
Gotcha, I'll rebase #5032 tomorrow |
|
BTW this was all very thoughtful but in the future no need to go out of the way to preserve my contributions especially if it's something this tiny! |
jessemapel
pushed a commit
that referenced
this pull request
Sep 22, 2022
* fixes for downloadIsisData * added changelog line * no more conda_prefix * tweaked do string * removed prints * made usgs sources download second * isis_data to usgs_data * update readme with correc paths to .conf and script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes random bugs that ended up in the new downloadIsisData script. Also patches the README to remove all mentions to .py that also somehow got through.
Related Issue
#5024
Motivation and Context
How Has This Been Tested?
Local install and this is the version running nightly on the isismgr_scripts repo
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: