Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some missing targets into rclone.conf #5042

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Conversation

Kelvinrr
Copy link
Collaborator

Description

rlcone.conf had some module missing for some reason, this adds them back in.

Related Issue

#5038

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.


Examples of how to run this program:

# download everything for tgo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download everything for the tgo cassis mission

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just TGO for the mission name. CaSSIS is the sensor.

isis/scripts/downloadIsisData Outdated Show resolved Hide resolved
isis/scripts/downloadIsisData Outdated Show resolved Hide resolved
isis/scripts/downloadIsisData Outdated Show resolved Hide resolved
args = create_rclone_arguments(dest, remote, dry_run, ntransfers)
rclone(command="sync", extra_args=args, config=cfg_path, redirect_stdout=False, redirect_stderr=False)
args = create_rclone_arguments(dest, remote, ntransfers, kwargs)
rclone(command="copy", extra_args=args, config=cfg_path, redirect_stdout=False, redirect_stderr=False)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This swap will cause existing files to be re-downloaded? In essence, is the rclone sync vs. copy the same different from the aws s3 sync vs. copy?

Copy link
Collaborator Author

@Kelvinrr Kelvinrr Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy checks if the file exists before re-copying. It should only re-copy if 1. the same file exists on different sources and 2. the file is newer. I would say re-download if another source has a newer version of the same file is probably desired? Shouldn't happen too much after we sanitize the USGS sources.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we want to take newer files, but it shouldn't happen too often. The kernels are always versioned as separate files

@jessemapel jessemapel merged commit f3f699b into DOI-USGS:dev Aug 30, 2022
jessemapel pushed a commit that referenced this pull request Sep 22, 2022
* adding some missing targets

* added kwargs to download scripts

* removed unused code

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants