added projection code #524
Conversation
ale/base/base.py
Outdated
| try: | ||
| from osgeo import gdal | ||
| except: | ||
| self._projection = None | ||
| return self._projection |
There was a problem hiding this comment.
Localized the import to keep the optional gdal stuff in one location without complicating things by adding some gdal module or something.
| run_contrained: | ||
| - gdal |
There was a problem hiding this comment.
will only install if it can do so without conflicts. important to co-install with ISIS.
| Group = Mapping | ||
| ProjectionName = Sinusoidal | ||
| CenterLongitude = 148.36859083039 | ||
| TargetName = MARS |
There was a problem hiding this comment.
just kinda shoved a projection into an MRO image for testing, I imagine the same to what a real image is like.
There was a problem hiding this comment.
Overall looks good, we need to get the geoTransform attached to the isd to finish this off.
We also need to define how those fields are accessed in ALE. I have written the functions to do so in USGSCSM, but will paste them here:
std::vector<double> getGeoTransform(json isd) {
std::vector<double> transform = {};
try {
transform = isd.at("geo_transform").get<std::vector<double>>();
} catch (std::exception &e) {
std::string originalError = e.what();
std::string msg = "Could not parse the geo_transform. ERROR: " + originalError + isd.dump();
throw std::runtime_error(msg);
}
return transform;
}
std::string getProjectionString(json isd) {
std::string projection_string = "";
try {
projection_string = isd.at("proj_string");
} catch (...) {
throw std::runtime_error("Could not parse the projection string.");
}
return projection_string;
}
| try: | ||
| from osgeo import gdal | ||
| except: | ||
| self._geotransform = (0.0, 1.0, 0.0, 0.0, 0.0, 1.0) |
There was a problem hiding this comment.
Im preeeetty sure this is the identity, probably good as a default.
There was a problem hiding this comment.
Yes that should identity for GDAL. https://github.com/OSGeo/gdal/blob/c642af0722d43bb337aaf86293129dbed576e534/alg/gdaltransformer.cpp#L1847
But just a warning, this is not same order for all packages.
|
@acpaquette I think we are on the same page here except Im using geotransfmrm without underscore. And prog_string is projection. Projection is NULL if it doesn't exist, otherwise prog4 string. Maybe I can change it to something else easier to parse? Otherwise geotransform being the identity when no transformation which I think makes sense. |
* added projection code * fixed test * added geotransform * addded indentity matrix * added to generic ISD * adding getters * addressed comment * more comment
Adds ability to add projections to usgscsm ISDs, part of the EIS projection support work.