Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hayabusa NIRS #532

Merged
merged 10 commits into from
May 26, 2023
Merged

Hayabusa NIRS #532

merged 10 commits into from
May 26, 2023

Conversation

jrcain-usgs
Copy link
Contributor

Redo of previous PR without absolute paths.

One of the tests may fail because of the projection/geotransform bug, addressed in #528

@jrcain-usgs jrcain-usgs changed the title Hayabusa nirs clean Hayabusa NIRS May 12, 2023
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just need a changelog entry and this can get merged

@jrcain-usgs
Copy link
Contributor Author

Changelog entry added.

@acpaquette
Copy link
Collaborator

@jrcain-usgs looks like the nirs test is failing now due to the merge of the projection fix. Can the test here be updated? You should just need to remove the projection and geotransform keywords in the truth ISD

acpaquette
acpaquette previously approved these changes May 19, 2023
@acpaquette acpaquette merged commit 8aa3b10 into DOI-USGS:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants