Mex fixes #541
Mex fixes #541
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 17.06% 17.03% -0.04%
==========================================
Files 53 53
Lines 5813 5824 +11
==========================================
Hits 992 992
- Misses 4821 4832 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -69,7 +69,7 @@ | |||
| [-8569.5561557859, 0.068566503695773, 142.857126402363]], | |||
| } | |||
|
|
|||
| class MexHrscPds3NaifSpiceDriver(LineScanner, Pds3Label, NaifSpice, RadialDistortion, Driver): | |||
| class MexHrscPds3NaifSpiceDriver(LineScanner, Pds3Label, NaifSpice, NoDistortion, Driver): | |||
There was a problem hiding this comment.
I think this was before we had a NoDistortion class/mixin in ALE. In the driver we define the distortion coefficients as all zeros:
@property
def odtk(self):
"""
The coefficients for the distortion model
Returns
-------
: list
Radial distortion coefficients. There is only one coefficient for LROC NAC l/r
"""
return [0.0, 0.0, 0.0]
I just changed it to remove duplicate code but didn't remove the odtk property. I will do that
| /* DATA OBJECT DEFINITIONS */ | ||
| Object = IMAGE | ||
| INTERCHANGE_FORMAT = BINARY | ||
| LINES = 400 | ||
| LINE_PREFIX_BYTES = 68 | ||
| LINE_SAMPLES = 1288 | ||
| SAMPLE_TYPE = MSB_INTEGER |
There was a problem hiding this comment.
why is all of this deleted?
There was a problem hiding this comment.
For whatever reason two pds3 labels existed in the file. One with 400 lines and the other with 15088 lines which is the actual number of lines in the image.
Using the real number of lines made testing easier
Fixes up MEX HRSC drivers for use in ISIS and USGSCSM