-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mariner10 driver and test #547
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #547 +/- ##
==========================================
- Coverage 16.99% 16.91% -0.09%
==========================================
Files 53 54 +1
Lines 5836 5865 +29
==========================================
Hits 992 992
- Misses 4844 4873 +29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Nice job on figuring out the driver structure along with the mixins. Just a few things to address before we can merge it in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking things look good! Were you able to compare it to the original spice data? That is, did you compare an isis
source spiceinit'd cube against an ale
source spiceinit'd cube
@acpaquette would that be Step 7 of the Step-by-Step? I've run |
@chkim-usgs Could we get an addition to the change log? After that this should be good to go! |
Added Mariner10 driver and tests.
Some insight:
NoDistortion
mixin as Viking and Voyager haveNoDistortion
in ALE despite both havingReseauDistortionMap
in ISIS (ISIS Mariner10 example)sensor_frame_id
is hard-coded to the frame id in ISIS Mariner10ephemeris_start_time
is calculated based off of the shutter open time calculation in ISIS Mariner10Tested with:
python -m pytest tests/pytests/test_mariner_drivers.py