-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ale dawn framing camera driver for ISIS3 Labels #567
Conversation
Edit: they in fact don't pass with the current state of the tests being not updated |
I dont understand, why is this one still failing? |
@Kelvinrr I believe I still need to add the label in the data area, working on that now |
@Kelvinrr basically I made a test data folder for the new kernels I need for this driver and it's testing but I am still trying to figure out whether these can be merged somewhat with the test kernels for the pds label dawn driver. Alot of the kernels makign this PR massive are shared between these two drivers and I wanted to avoid duplicating kernel data in the test area if possible so for right now I have just removed some of the larger kernels that were just bloat as far as I know but still am not sure whether these two test data directories can be merged. After either merging or keeping these test data directories separate I can finish coordinating the test script to incorporate the new data. |
799165d
to
76cefa8
Compare
it looks like the ubuntu 3.8 runner and the 3.9 ubuntu runner are both failing due to an import in conftest which wasn't touched with this PR, I believe those errors are outside the scope of this PR though |
It looks good to me, but Im a little worried about those tests, might be an upstream issue. |
yeah, last PR merge is failing. From talking to adam about this the tests were passing before this happened. We should probably try to get these tests back to normal as part of continuous support. |
Adding the ALE dawnfc driver, the tests still need to be adapted to use the new isis3 label driver alongside the pds3 label driver. The preliminary comparison of Ale and ISIS outputs at this point looks promising, the ck and spk start/end times still need to be tuned according to the ISIS3 camera model for dawn framing camera.