Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radtan distortion #575

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add radtan distortion #575

merged 1 commit into from
Nov 7, 2023

Conversation

oleg-alexandrov
Copy link
Collaborator

@oleg-alexandrov oleg-alexandrov commented Nov 7, 2023

Add support for the radial + tangential distortion model. This has 5 distortion coefficients, stored in order k1, k2, p1, p2, k3. The k1, k2, k3 coefficients are for radial distortion, and p1 and p2 for tangential distortion. This was validated with the OpenCV implementation using the function cv::projectPoints(). More background in DOI-USGS/usgscsm#465.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@acpaquette
Copy link
Collaborator

@oleg-alexandrov Is the plan for this to just inject the distortion model after you create an ISD?

@oleg-alexandrov
Copy link
Collaborator Author

My plan is to use this distortion model for CSM cameras I create in ASP. That because this does not correspond to any sensor that ALE supports. I only added enough logic to ensure ALE and CSM can load and process files having this distortion model.

@acpaquette
Copy link
Collaborator

Is there some driver that will eventually go into ALE that uses this model?

@oleg-alexandrov
Copy link
Collaborator Author

Probably not. Unless it is shown that for some sensor the radtan model is better than any existing model. My plan is to use this with Earth cameras, so outside existing driver logic.

@oleg-alexandrov
Copy link
Collaborator Author

If the changes are approved, can they be pulled in? There's more discussion to be had at the usgscsm repo, but these ale changes appear small enough. (And without this brought in the usgscsm build fails.)

@acpaquette
Copy link
Collaborator

@oleg-alexandrov It's approved does someone internal to the DOI-USGS still need to hit merge?

@acpaquette acpaquette merged commit d5571c1 into DOI-USGS:main Nov 7, 2023
6 of 13 checks passed
@oleg-alexandrov
Copy link
Collaborator Author

I don't have write access to this repo (and no need to have this access). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants