Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ody Driver Fixes #582

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Ody Driver Fixes #582

merged 8 commits into from
Mar 13, 2024

Conversation

amystamile-usgs
Copy link
Contributor

@amystamile-usgs amystamile-usgs commented Dec 15, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 14.67%. Comparing base (58a8ee4) to head (283e82a).

Files Patch % Lines
ale/drivers/ody_drivers.py 0.00% 94 Missing ⚠️
ale/base/type_distortion.py 0.00% 4 Missing ⚠️
ale/drivers/__init__.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   14.84%   14.67%   -0.17%     
==========================================
  Files          59       59              
  Lines        6697     6772      +75     
==========================================
  Hits          994      994              
- Misses       5703     5778      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amystamile-usgs
Copy link
Contributor Author

Seeing an issue with Themis VIR where:

with sclkCode: -53 and clockValue: 1023406812.230

I am seeing two different results:

CSpice scs2e_c is returning 392211096.4307215.

SpiceyPy spice.scs2e is returning 392211095.6221291.

@acpaquette have you ever run into this before?

@acpaquette
Copy link
Collaborator

Seeing an issue with Themis VIR where:

with sclkCode: -53 and clockValue: 1023406812.230

I am seeing two different results:

CSpice scs2e_c is returning 392211096.4307215.

SpiceyPy spice.scs2e is returning 392211095.6221291.

@acpaquette have you ever run into this before?

I have not seen this, I would make sure your times are the same to the 16th sig fig and that the codes are the same

@amystamile-usgs amystamile-usgs changed the title Draft: Disabled Drivers - Ody Driver Fixes Ody Driver Fixes Mar 12, 2024
@amystamile-usgs
Copy link
Contributor Author

Seeing an issue with Themis VIR where:
with sclkCode: -53 and clockValue: 1023406812.230
I am seeing two different results:
CSpice scs2e_c is returning 392211096.4307215.
SpiceyPy spice.scs2e is returning 392211095.6221291.
@acpaquette have you ever run into this before?

I have not seen this, I would make sure your times are the same to the 16th sig fig and that the codes are the same

Figured out that python's str() function was dropping the zero and causing it to convert the time for 1023406812.023 instead of 1023406812.230.

@amystamile-usgs amystamile-usgs marked this pull request as ready for review March 12, 2024 18:27
Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go after a changelog entry!

@amystamile-usgs amystamile-usgs merged commit 62f7688 into DOI-USGS:main Mar 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants