Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #583

Merged
merged 13 commits into from
Mar 5, 2024
Merged

Small fixes #583

merged 13 commits into from
Mar 5, 2024

Conversation

acpaquette
Copy link
Collaborator

Minor fixes for various drivers going into a 1.0 release.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 15.44%. Comparing base (6618a19) to head (801339f).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/osirisrex_drivers.py 0.00% 14 Missing ⚠️
ale/drivers/viking_drivers.py 0.00% 9 Missing ⚠️
ale/drivers/nh_drivers.py 0.00% 3 Missing ⚠️
ale/drivers/msi_drivers.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   15.47%   15.44%   -0.03%     
==========================================
  Files          57       57              
  Lines        6423     6434      +11     
==========================================
  Hits          994      994              
- Misses       5429     5440      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kelvinrr
Copy link
Collaborator

Can we get a changelog? Also, a breakdown of the fixes?

@acpaquette
Copy link
Collaborator Author

@Kelvinrr Added changelog entries the describe changes

Comment on lines +103 to +105
@property
def sensor_model_version(self):
return 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any existing tests for the cam model version stuff that we need to add or update?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will double check

AustinSanders
AustinSanders previously approved these changes Mar 1, 2024
@acpaquette acpaquette requested a review from AustinSanders March 4, 2024 19:32
@acpaquette acpaquette merged commit 54c3e7b into DOI-USGS:main Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants