-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pvl loads fix #587
Pvl loads fix #587
Conversation
…or that into the original PR adding it
…ad in a PVLModule
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 15.82% 15.81% -0.01%
==========================================
Files 56 56
Lines 6283 6284 +1
==========================================
Hits 994 994
- Misses 5289 5290 +1 ☔ View full report in Codecov by Sentry. |
This PR needs to be based off of main rather than whatever branch it was branched from. Easiest way to do that is to just create a new branch from main and cherry-pick the changes into it |
…ested and run against to find one that works. there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
Addresses #586 and compliments #584 by allowing that verification script to account for these changes which allow PVLModules to be used with ale.load(s).
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: