Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pvl loads fix #587

Closed
wants to merge 21 commits into from
Closed

Pvl loads fix #587

wants to merge 21 commits into from

Conversation

antonhibl
Copy link
Contributor

@antonhibl antonhibl commented Jan 11, 2024

Addresses #586 and compliments #584 by allowing that verification script to account for these changes which allow PVLModules to be used with ale.load(s).

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@antonhibl antonhibl self-assigned this Jan 11, 2024
@antonhibl antonhibl requested a review from acpaquette January 11, 2024 21:42
antonhibl added a commit to antonhibl/ale that referenced this pull request Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (ec88933) to head (6bb46f4).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
ale/base/label_isis.py 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   15.82%   15.81%   -0.01%     
==========================================
  Files          56       56              
  Lines        6283     6284       +1     
==========================================
  Hits          994      994              
- Misses       5289     5290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonhibl antonhibl added the bug Something isn't working label Jan 11, 2024
@acpaquette
Copy link
Collaborator

This PR needs to be based off of main rather than whatever branch it was branched from. Easiest way to do that is to just create a new branch from main and cherry-pick the changes into it

antonhibl added a commit to antonhibl/ale that referenced this pull request Jan 17, 2024
…ested and run against to find one that works.

there is a small note to make about the use of pvl.loads() in this script. I commented out 2 lines using that function and had to change to variable names in the subsequent lines as this pvl.loads() function won't work as expected until DOI-USGS#587 is merged to apply the bug fix to that method; that fix will allow ale.loads() to read in PVLObjects, currently because the lines are commented ale.loads() just reads in the image files themselves which still works but requires more overhead in ale.loads().
@antonhibl antonhibl closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants