Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msl Landed Fix #590

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Msl Landed Fix #590

merged 2 commits into from
Feb 29, 2024

Conversation

acpaquette
Copy link
Collaborator

Updated what the "landed" props argument does for MSL. To get accurate sky projections in ISIS we just need to invert the focal length and set the spacecraft (rover) position to the center of the target body.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.71%. Comparing base (775ff21) to head (975d2db).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/msl_drivers.py 0.00% 3 Missing ⚠️
ale/base/type_sensor.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   15.82%   15.71%   -0.11%     
==========================================
  Files          56       57       +1     
  Lines        6283     6326      +43     
==========================================
  Hits          994      994              
- Misses       5289     5332      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry and it should be good to go!

@acpaquette acpaquette merged commit 0d4cfb6 into DOI-USGS:main Feb 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants