Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hayabusa amica Ephemeris Fix #592

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

acpaquette
Copy link
Collaborator

Fixes a small time difference between ISIS and ALE when computing the center ephemeris time

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry then should be good to go

AustinSanders
AustinSanders previously approved these changes Feb 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 15.48%. Comparing base (1d786e1) to head (32c9624).

Files Patch % Lines
ale/drivers/hayabusa_drivers.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   15.49%   15.48%   -0.01%     
==========================================
  Files          57       57              
  Lines        6417     6420       +3     
==========================================
  Hits          994      994              
- Misses       5423     5426       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acpaquette acpaquette merged commit c9656f6 into DOI-USGS:main Mar 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants