Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable haybusa2 ONC IsisLabelNaifSpice driver #596

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

acpaquette
Copy link
Collaborator

@acpaquette acpaquette commented Mar 4, 2024

Enables the hayabusa2 ONC ISISLabelNaifSpice driver for use in ISIS to get spice data. See the attached image for verification of ephemeris data:
Screenshot 2024-03-04 at 12 47 16 PM

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Mar 5, 2024

Was the driver okay to begin with?

also needs a changelog entry

@acpaquette
Copy link
Collaborator Author

@Kelvinrr The ephemeris data that the driver produces is very close to ISIS as is. The driver was likely disabled to prevent people from making ISDs as the USGSCSM model has not been compared to the ISIS model and is likely incorrect.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (6618a19) to head (91d7c83).
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   15.47%   15.14%   -0.34%     
==========================================
  Files          57       58       +1     
  Lines        6423     6563     +140     
==========================================
  Hits          994      994              
- Misses       5429     5569     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acpaquette acpaquette merged commit 025cea7 into DOI-USGS:main Mar 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants