Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WQP TODO: implement other services like Organization, Activity, etc. #35

Closed
jbousquin opened this issue Aug 12, 2021 · 1 comment
Closed

Comments

@jbousquin
Copy link
Contributor

wqp.py lines 6-7 has this as a TODO. Seems easy enough to implement brute force following what was done for stations. How are these for function names (url term), and any that are missing or may have conflicts/complications?

  • what_organizations ('Organization')
  • what_projects ('Project')
  • what_activities ('Activity')
  • what_detection_limits ('ResultDetectionQuantitationLimit')
  • what_habitat_metrics ('BiologicalMetric')
  • what_project_weights ('ProjectMonitoringLocationWeighting')
  • what_activity_metrics ('ActivityMetric')*

All but activity metrics appear queriable using location (may just not be activity metrics where I tested) but they are not all queriable by siteid. For subsets of results (narrow, biological metadata) just pass dataProfile as a get_results param.

thodson-usgs pushed a commit that referenced this issue Oct 4, 2021
* Added functions to query 7 more WQP tables (issue #35).

* Updated base_url to end with 'data/'. Although results and sites were redirected properly this is the full WQP base url and other data tables were not redirected properly.

* Added tests for new functions to wqp_test.py. Updated request_url for test_get_ratings() and test_what_sites() to pass md.url assert and reflect updated base_url.

* Added csv results for 7 new tests in wqp_test.py.
@thodson-usgs
Copy link
Collaborator

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants