Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings for qwdata deprecation #56

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

elbeejay
Copy link
Contributor

@elbeejay elbeejay commented Nov 22, 2022

  • adds deprecation warnings to calls to the qwdata service as well as a warning in the documentation
  • drops CI support for python 3.6 as it is no longer included in the "ubuntu-latest" image (hence the failing CI build)

@lstanish-usgs this is the extent of where we would place warnings for this deprecation - feel free to propose changes to the wording.

elbeejay and others added 3 commits November 22, 2022 17:01
update doc warning for qw data changes to include contact email
drop CI build for python 3.6 as it is no longer included in the ubuntu-latest image
@elbeejay elbeejay marked this pull request as ready for review November 28, 2022 14:56
@elbeejay
Copy link
Contributor Author

@thodson-usgs let me know what you think. Very minor PR but would rather not merge PRs without someone else laying eyes on 'em.

Copy link
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lstanish-usgs could we give a date for which this retirement is planned? Or else ask Laura to revise the vignette?
I realize it could change, but the vignette says the web service will shut down in spring 2022, which is confusing.

@thodson-usgs thodson-usgs merged commit d72012b into DOI-USGS:master Nov 28, 2022
@lstanish-usgs
Copy link
Collaborator

@thodson-usgs Thanks for catching that. I think we should update the vignette, will reach out to Laura.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants