Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the path to _version.py in pyproject.toml #85

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

thodson-usgs
Copy link
Collaborator

No description provided.

@thodson-usgs thodson-usgs linked an issue Feb 10, 2023 that may be closed by this pull request
Copy link
Contributor

@elbeejay elbeejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a _version.py file (at least I don't see one in this repository)

@thodson-usgs
Copy link
Collaborator Author

thodson-usgs commented Feb 10, 2023

I just learned about this the hard way, when I accidentally committed _version.py on another project (Don't worry, I've added it to .gitignore.)
_version.py is dynamically generated by setuptools. Basically, setuptools will pull the version info from the most recent tag, apply that version to the PyPI upload and write a new _version.py, so that dataretrieval.__version__ returns the correct version info.

@thodson-usgs thodson-usgs merged commit d005aa1 into master Feb 10, 2023
elbeejay pushed a commit to elbeejay/dataretrieval-1 that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in project.toml
2 participants