Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded variables #122

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Remove unneeded variables #122

merged 1 commit into from
Apr 9, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Apr 9, 2024

The replication password is set lower in the wf46/wf47 as besides the risk for leaking the database we would also setup replication on the analyst instance.
The ICPC-tools variables are not relevant here as we at this point don't setup the CDS.

The replication password is set lower in the wf46/wf47 as besides the
risk for leaking the database we would also setup replication on the
analyst instance.
The ICPC-tools variables are not relevant here as we at this point don't
setup the CDS.
Copy link

gitguardian bot commented Apr 9, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Username Password efc805c provision-contest/ansible/group_vars/all/secret.yml.example View secret
- Generic Password efc805c provision-contest/ansible/group_vars/all/secret.yml.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vmcj vmcj merged commit 32f899b into DOMjudge:wfluxor Apr 9, 2024
2 of 3 checks passed
@vmcj vmcj deleted the wfluxor_cleanup branch April 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants