Skip to content

Commit

Permalink
regex/cn9k: remove rule compiler
Browse files Browse the repository at this point in the history
Nobody knows how to build the feature.
When the dependency "rxp_compiler" is found,
the header file is not available:

drivers/regex/cn9k/cn9k_regexdev_compiler.c:12:10: fatal error:
	rxp-compiler.h: No such file or directory

It seems that it depends on a proprietay library.
According to what was discussed in the Technical Board:
http://mails.dpdk.org/archives/dev/2019-June/135847.html
the dependency must be "freely available".

Bugzilla ID: 1232

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Jerin Jacob <jerinj@marvell.com>
  • Loading branch information
tmonjalo committed Jul 3, 2023
1 parent 93a4b3b commit 6825dc2
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 258 deletions.
3 changes: 1 addition & 2 deletions doc/guides/prog_guide/regexdev.rst
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,7 @@ The configuration mode is depended on the PMD capabilities.

Online rule configuration is done using the following API functions:
``rte_regexdev_rule_db_update`` which add / remove rules from the rules
precompiled list, and ``rte_regexdev_rule_db_compile_activate``
which compile the rules and loads them to the RegEx HW.
precompiled list.

Offline rule configuration can be done by adding a pointer to the compiled
rule database in the configuration step, or by using
Expand Down
10 changes: 1 addition & 9 deletions drivers/regex/cn9k/cn9k_regexdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

/* REE common headers */
#include "cn9k_regexdev.h"
#include "cn9k_regexdev_compiler.h"


/* HW matches are at offset 0x80 from RES_PTR_ADDR
Expand Down Expand Up @@ -697,12 +696,6 @@ cn9k_ree_queue_pair_setup(struct rte_regexdev *dev, uint16_t qp_id,
return 0;
}

static int
cn9k_ree_rule_db_compile_activate(struct rte_regexdev *dev)
{
return cn9k_ree_rule_db_compile_prog(dev);
}

static int
cn9k_ree_rule_db_update(struct rte_regexdev *dev,
const struct rte_regexdev_rule *rules, uint16_t nb_rules)
Expand Down Expand Up @@ -834,8 +827,7 @@ static struct rte_regexdev_ops cn9k_ree_ops = {
.dev_attr_get = NULL,
.dev_attr_set = NULL,
.dev_rule_db_update = cn9k_ree_rule_db_update,
.dev_rule_db_compile_activate =
cn9k_ree_rule_db_compile_activate,
.dev_rule_db_compile_activate = NULL,
.dev_db_import = cn9k_ree_rule_db_import,
.dev_db_export = cn9k_ree_rule_db_export,
.dev_xstats_names_get = NULL,
Expand Down
228 changes: 0 additions & 228 deletions drivers/regex/cn9k/cn9k_regexdev_compiler.c

This file was deleted.

11 changes: 0 additions & 11 deletions drivers/regex/cn9k/cn9k_regexdev_compiler.h

This file was deleted.

8 changes: 0 additions & 8 deletions drivers/regex/cn9k/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,8 @@ if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
subdir_done()
endif

lib = cc.find_library('rxp_compiler', required: false)
if lib.found()
ext_deps += lib
ext_deps += cc.find_library('stdc++', required: true)
cflags += ['-DREE_COMPILER_SDK']
endif

sources = files(
'cn9k_regexdev.c',
'cn9k_regexdev_compiler.c',
)

deps += ['bus_pci', 'regexdev']
Expand Down

0 comments on commit 6825dc2

Please sign in to comment.