Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website bugs on mobile #23

Closed
Gaelan opened this issue Jul 8, 2023 · 13 comments
Closed

Website bugs on mobile #23

Gaelan opened this issue Jul 8, 2023 · 13 comments
Assignees
Labels
bug Something isn't working open DSAC Open Repo summer2024 Summer Fellowship and Internship Related Tasks

Comments

@Gaelan
Copy link
Contributor

Gaelan commented Jul 8, 2023

Tried to show someone the site on my phone, and noticed a couple bugs:

  • the “menu” button doesn’t work
  • the project cards are too wide, causing a horizontal scroll bar
@Gaelan
Copy link
Contributor Author

Gaelan commented Jul 10, 2023

Project cards being too wide: fixed by FullHuman/purgecss#1133

@natalialuzuriaga
Copy link
Collaborator

7/15:

  • Starting on this today
  • We can apply bug fixes for this to metrics site

@Firebird1029
Copy link
Member

#35 is ready for review, I am not sure how to deploy to prod but once done the issues should be fixed

@natalialuzuriaga
Copy link
Collaborator

7/19:

  • PR is ready for review

@decause-gov
Copy link
Contributor

7/22:

@Firebird1029
Copy link
Member

@Firebird1029 take before and after pics of website

@decause-gov
Copy link
Contributor

07/26:

  • Re-adding the easi-app repo that was moved into repos.js
  • For now, replacing the repo with the location it's moved to, but, there is an API endpoint to resolve this. Discussion in Fix horizontal scroll bug #35 (review)
  • ACTION: file a new ticket as per discussion link above, edit the repos.js file, and then we close this one after merge 🐛

@Firebird1029
Copy link
Member

Firebird1029 commented Jul 26, 2024

Created new issue #39, PR is ready for re-review: #35

@decause-gov
Copy link
Contributor

07/29:

  • New issue filed, PR sent. Changed repo name.
  • Blocking on PR review (@natalialuzuriaga will review)
  • Goal: Push to main, update live site.

@decause-gov
Copy link
Contributor

08/02:

  • PR is merged! Won't show on live site until there are config changes.
  • The metrics site, when Gaelan built the Open website, there were specific tools, but there are bugs now. CSS bugs, pass-through bugs, etc, that were made with Metrics, but not with /Open site. Nat is working on them!
  • Leaving this open til the build tools updates are complete.
  • IDEA: use the same build tools as metrics.

@decause-gov
Copy link
Contributor

08/03:

  • Waiting on Nat to return 8/12

@IsaacMilarky
Copy link
Collaborator

8/9:

  • Build hasn't worked but PR has been merged
  • Still pending

@natalialuzuriaga
Copy link
Collaborator

8/12:

  • Meeting on the books later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working open DSAC Open Repo summer2024 Summer Fellowship and Internship Related Tasks
Development

No branches or pull requests

5 participants