Couple JS/CSS fixes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary to make the JS progressive enhancement machinery work when loading uswds piecewise as ES modules.
Otherwise, PurgeCSS deletes classes created by JS code.
|
LGTM +1 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assets: couple JS/CSS fixes
Problem
The menu button on mobile doesn't work (#23), and the "here's how you know" on the banner doesn't either.
Solution
Two separate fixes for the two issues - lumped into one PR because they're both tiny:
window.uswdsPresent = true, because the piece that's suppose to do that isn't accessible as an ES module.Test Plan
Manually tested - it works!