Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent positions for different subviews #2023

Open
MoritzWeber0 opened this issue Nov 19, 2024 · 1 comment · May be fixed by #2115
Open

Use consistent positions for different subviews #2023

MoritzWeber0 opened this issue Nov 19, 2024 · 1 comment · May be fixed by #2115

Comments

@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Nov 19, 2024

From the project details page, we have three different subviews (Link Tool, Configure Project, and Configure Model). All three subviews have a different positions for the cards they contain (full-width, centered, on the left). It would be nice for these views to look more consistent

Originally posted by @zusorio in #1901 (comment)

@zusorio
Copy link
Member

zusorio commented Jan 9, 2025

Making a list of all subviews and their layouts:

  • Configure Project (/project/:slug/metadata) → Single Card, on the left
  • Configure Model (/project/:slug/model/:slug/metadata) → Single Card, full-width
  • Restrictions (/project/:slug/model/:slug/restrictions) → Single Card, full-width, looks kind of wonky
  • Model Sources (/project/:slug/model/:slug/modelsources/git-model/:slug) → Single Card, centered
  • Edit Git Server Instance (/settings/modelsources/git-instance/:slug) → Single Card, on the left
  • Pure Variants (/settings/integrations/pure-variants) → Single Card, centered

There's a few more subviews that have multiple cards on the left. In my opinion, making all subviews left-aligned is probably the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging a pull request may close this issue.

2 participants