Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove deprecated interface in authentication #1437

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

romeonicholas
Copy link
Contributor

Fix for the following deprecation warning:

capellacollab/core/authentication/init.py:14
capellacollab/core/authentication/init.py:14
/Users/nicholasromeo/code/capella-collab-manager/backend/capellacollab/core/authentication/init.py:14: DeprecationWarning: SelectableGroups dict interface is deprecated. Use select.
for i in metadata.entry_points()[

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (aebe3cd) to head (9e6e4b4).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   74.75%   74.82%   +0.07%     
==========================================
  Files         169      169              
  Lines        5656     5709      +53     
  Branches      656      665       +9     
==========================================
+ Hits         4228     4272      +44     
- Misses       1280     1288       +8     
- Partials      148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeonicholas romeonicholas marked this pull request as ready for review March 19, 2024 10:29
@romeonicholas romeonicholas changed the title feat: Remove deprecated interface in authentication fix: Remove deprecated interface in authentication Mar 19, 2024
@romeonicholas romeonicholas force-pushed the remove-deprecated-dict-interface branch from 014e434 to c728b83 Compare March 19, 2024 10:43
@MoritzWeber0 MoritzWeber0 requested a review from dominik003 March 20, 2024 11:11
Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just found a second use of the deprecated variant in our documentation that should be adjusted before we merge this.

@romeonicholas romeonicholas force-pushed the remove-deprecated-dict-interface branch from c728b83 to 9e6e4b4 Compare March 21, 2024 14:09
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit d22f6fd into main Mar 21, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the remove-deprecated-dict-interface branch March 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants