Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Storybook to PR acceptance criteria #1494

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

MoritzWeber0
Copy link
Member

No description provided.

@MoritzWeber0 MoritzWeber0 requested a review from dominik003 April 5, 2024 13:39
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.94%. Comparing base (4f97466) to head (fa6b761).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files         170      170           
  Lines        5668     5668           
  Branches      650      650           
=======================================
  Hits         4361     4361           
  Misses       1161     1161           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the comment is resolved it can be merged.

docs/docs/development/frontend/storybook.md Show resolved Hide resolved
@MoritzWeber0 MoritzWeber0 merged commit 802a84c into main Apr 15, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the storybook-acceptance-criteria branch April 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants