feat: Add diagram cache stories and combine story objects #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves most of the storybook objects into the `src/storybook` directory and makes them generally available. This greatly improves the readability of the stories and also reduces duplication.
|
A Storybook preview is available for commit 0eb1a2f. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
=======================================
Coverage 78.36% 78.36%
=======================================
Files 171 171
Lines 5778 5778
Branches 663 663
=======================================
Hits 4528 4528
Misses 1098 1098
Partials 152 152 ☔ View full report in Codecov by Sentry. |
dominik003
added a commit
that referenced
this pull request
May 6, 2024
This changes the previous usage of `ngIf` and `ngFor` to the new angular control flow introduced in angular v17. This not only improves code readability, but also allows better alignment and combination of conditions. To test this, we introduced diagram cache stories in #1549, which can be compared to the stories in this PR.
dominik003
force-pushed
the
feat-add-diagram-cache-stories
branch
from
ae630ff to
e294272
Compare
dominik003
added a commit
that referenced
this pull request
May 6, 2024
This changes the previous usage of `ngIf` and `ngFor` to the new angular control flow introduced in angular v17. This not only improves code readability, but also allows better alignment and combination of conditions. To test this, we introduced diagram cache stories in #1549, which can be compared to the stories in this PR.
dominik003
changed the title
MoritzWeber0
reviewed
May 7, 2024
frontend/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.docs.mdx
Outdated
Show resolved
Hide resolved
MoritzWeber0
approved these changes
May 7, 2024
frontend/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.stories.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.stories.ts
Outdated
Show resolved
Hide resolved
MoritzWeber0
force-pushed
the
feat-add-diagram-cache-stories
branch
from
e294272 to
3f996da
Compare
|
MoritzWeber0
pushed a commit
that referenced
this pull request
May 7, 2024
This changes the previous usage of `ngIf` and `ngFor` to the new angular control flow introduced in angular v17. This not only improves code readability, but also allows better alignment and combination of conditions. To test this, we introduced diagram cache stories in #1549, which can be compared to the stories in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several stories to the model diagram cache. It also moves most of the storybook objects into the
src/storybookdirectory and makes them generally available, which greatly improves the readability of the stories and also reduces duplication.