Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve accessibility for some buttons #1557

Merged
merged 1 commit into from
May 10, 2024

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented May 7, 2024

This fixes some Sonarcloud alerts. The touched components are migrated to the new control flow.

@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review May 7, 2024 11:49
Copy link

github-actions bot commented May 7, 2024

A Storybook preview is available for commit aa734e0.
View Storybook
View Chromatic build

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (c2fa082) to head (5659065).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1557   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files         171      171           
  Lines        5778     5778           
  Branches      663      663           
=======================================
  Hits         4528     4528           
  Misses       1098     1098           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 force-pushed the better-keyboard-support branch 4 times, most recently from e583580 to b5b4ccb Compare May 8, 2024 15:14
This fixes some Sonarcloud alerts.
@MoritzWeber0 MoritzWeber0 force-pushed the better-keyboard-support branch from b5b4ccb to 5659065 Compare May 8, 2024 15:32
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 0665eb5 into main May 10, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the better-keyboard-support branch May 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant