Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add delay to let mat-error animation complete #1842

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

MoritzWeber0
Copy link
Member

The mat-error animation didn't complete for an invalid input of the ManageGitModelComponent.

The mat-error animation didn't complete for an invalid input
of the ManageGitModelComponent.
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (b3b658b) to head (5907403).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1842   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         194      194           
  Lines        6455     6455           
  Branches      713      713           
=======================================
  Hits         5423     5423           
  Misses        876      876           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 25, 2024

A Storybook preview is available for commit a7ba96c.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

This report was generated by comparing a7ba96c with b3b658b.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 284
change 4
new 0
delete 0
📝 Report

Differences

Model Components_Model Sources_Git_Invalid URL_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Invalid URL_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_Git_Add Instance_With Values_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_Git_Add Instance_With Values_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 merged commit ab7e1cc into main Sep 25, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the wait-to-capture-screenshot branch September 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant