Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for nodeSelector #1863

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat: Add support for nodeSelector #1863

merged 1 commit into from
Oct 1, 2024

Conversation

MoritzWeber0
Copy link
Member

The nodeSelector can be defined in the values.yaml for the session pods and the management portal pods individually.

The `nodeSelector` can be defined in the `values.yaml` for the session pods
and the management portal pods individually.
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Oct 1, 2024

This report was generated by comparing 6dd890f with d06b4b4.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 302
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit ba1c10f into main Oct 1, 2024
28 of 29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the node-selector branch October 1, 2024 14:18
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (d06b4b4) to head (d13702c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1863   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files         197      197           
  Lines        6540     6541    +1     
  Branches      723      723           
=======================================
+ Hits         5529     5530    +1     
  Misses        851      851           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant