Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to filter trainings in project view #1937

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Oct 30, 2024

Add the ability to show only projects or only trainings in the project view.

Closes #1821

@zusorio zusorio requested a review from MoritzWeber0 as a code owner October 30, 2024 15:57
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (3727209) to head (8c3b9c3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         211      211           
  Lines        6875     6875           
  Branches      472      472           
=======================================
  Hits         5830     5830           
  Misses        879      879           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 30, 2024

A Storybook preview is available for commit ae12771.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Add the ability to show only projects or only trainings in the project view.

Closes #1821
Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

This report was generated by comparing ae12771 with 3727209.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 346
change 4
new 0
delete 0
📝 Report

Differences

Project Components_Project Overview_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Project Overview_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Project Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Project Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great feature!

@MoritzWeber0 MoritzWeber0 merged commit a46a5cb into main Oct 31, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the filter-trainings branch October 31, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for trainings / projects in project overview
2 participants