Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Improve Storybook mock names and services #1987

Merged
merged 1 commit into from
Nov 13, 2024
Merged

test: Improve Storybook mock names and services #1987

merged 1 commit into from
Nov 13, 2024

Conversation

MoritzWeber0
Copy link
Member

  • Use more realistic mock names than names containing "fake"
  • Use new provider structure to inject providers in Stories
  • Remove chromatic viewpoints (not used anymore)

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (fb961e2) to head (ed2ed1c).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1987   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         212      212           
  Lines        7032     7032           
  Branches      492      492           
=======================================
  Hits         5948     5948           
  Misses        924      924           
  Partials      160      160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

A Storybook preview is available for commit 0def1b0.
➡️ View Storybook
➡️ View Chromatic build

@MoritzWeber0
test: Improve Storybook mock names and services
ed2ed1c 
- Use more realistic mock names than names containing "fake"
- Use new provider structure to inject providers in Stories
- Remove chromatic viewpoints (not used anymore)
@MoritzWeber0 MoritzWeber0 force-pushed the storybook-better-mock-names branch from 03f5785 to ed2ed1c Compare November 13, 2024 11:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

This report was generated by comparing 0def1b0 with fb961e2.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 251
change 107
new 0
delete 0
📝 Report

Differences

Model Components_Init Model_General_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Init Model_General_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Job ID_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Job ID_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_As Global Admin_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_As Global Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_As Project Admin_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_As Project Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Existing Git Model Editing_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Existing Git Model Editing_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Existing Git Model_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Git_Existing Git Model_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_With Repository As Admin_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_With Repository As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_Request Sent_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_Request Sent_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Admin_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Project Admin_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Project Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_Request Sent_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_Request Sent_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Audit Log_General_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Audit Log_General_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Readonly Session Success State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Readonly Session Success State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Shared Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Shared Session_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Loading Session Info_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Loading Session Info_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Shared Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Shared Session_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_With Session Token_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_With Session Token_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Without Session Token_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Without Session Token_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Without Team For Capella_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Connection Dialog_Without Team For Capella_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Max Number Of Models Exceeded_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Max Number Of Models Exceeded_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Model Selected And Start Session Possible_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Model Selected And Start Session Possible_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Show Note For Compatible Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Create Readonly Session Dialog_Show Note For Compatible Session_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session History_Resolved Session History.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_All Selected_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_All Selected_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Sharing Dialog_Default_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Sharing Dialog_Default_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_One Session Tiling Pending_desktop.png

actual Actual

⚠️ report is omitted because comment body size limitation exceeded. Please check report in artifact.

@MoritzWeber0 MoritzWeber0 merged commit 83cc2f3 into main Nov 13, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the storybook-better-mock-names branch November 13, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MoritzWeber0