Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow users to copy t4c token from session viewer #2040

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Nov 26, 2024

Closes #2010

Copy link

sonarcloud bot commented Nov 26, 2024

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (6489656) to head (45d0db3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         225      225           
  Lines        7411     7411           
  Branches      513      513           
=======================================
  Hits         6334     6334           
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

A Storybook preview is available for commit e5e295c.
➡️ View Storybook
➡️ View Chromatic build

Copy link

This report was generated by comparing e5e295c with 6489656.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 402
change 10
new 0
delete 0
📝 Report

Differences

Session Components_Session Viewer_One Session Tiling Pending_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_One Session Tiling Pending_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_One Successful Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_One Successful Session_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Floating_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Floating_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Tiling Pending_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Tiling Pending_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Tiling_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Viewer_Two Sessions Tiling_mobile.png

actual Actual
expected Expected
difference Difference

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, this will make the life of our users a bit easier! 👍

@MoritzWeber0 MoritzWeber0 merged commit 39d0574 into main Nov 29, 2024
27 of 29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the t4c-token-in-session-viewer branch November 29, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button to copy TeamForCapella session token from Internal Session Viewer
2 participants