Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change feedback prompt for trainings #2042

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Nov 28, 2024

No description provided.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (eb01c8d) to head (b92afeb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2042   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         224      224           
  Lines        7397     7397           
  Branches      513      513           
=======================================
  Hits         6322     6322           
  Misses        911      911           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 28, 2024

A Storybook preview is available for commit 67a0fad.
➡️ View Storybook
➡️ View Chromatic build

Copy link

This report was generated by comparing 7d9be49 with 6489656.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 404
change 8
new 0
delete 0
📝 Report

Differences

Session Components_Feedback_Long Hint_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Long Hint_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_No Sessions_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_No Sessions_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Short Hint_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Short Hint_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 marked this pull request as draft December 5, 2024 14:38
@zusorio zusorio marked this pull request as ready for review December 9, 2024 09:40
Copy link

sonarqubecloud bot commented Dec 9, 2024

@MoritzWeber0 MoritzWeber0 merged commit 73c7fc5 into main Dec 9, 2024
29 of 30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the training-feedback branch December 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants