Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lost open animation of collapse #827

Merged
merged 1 commit into from
Nov 21, 2022
Merged

fix: fix lost open animation of collapse #827

merged 1 commit into from
Nov 21, 2022

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 collapse 组件丢失打开动画的问题
  • 修复 collapse header 在打开和关闭的情况下会出现抖动的问题

Related Issues

Closed #825

@mortalYoung mortalYoung added the bug Something isn't working label Nov 21, 2022
@mortalYoung mortalYoung requested a review from wewoor November 21, 2022 07:42
@mortalYoung mortalYoung self-assigned this Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 91.06% // Head: 91.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5d947c2) compared to base (d697d0b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   91.06%   91.07%   +0.01%     
==========================================
  Files         180      180              
  Lines        5795     5802       +7     
  Branches     1405     1408       +3     
==========================================
+ Hits         5277     5284       +7     
  Misses        512      512              
  Partials        6        6              
Impacted Files Coverage Δ
src/components/collapse/index.tsx 100.00% <100.00%> (ø)
src/model/workbench/layout.ts 100.00% <0.00%> (ø)
src/services/workbench/layoutService.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit d1cdbe1 into main Nov 21, 2022
@wewoor wewoor deleted the fix/collapse branch November 21, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: lost the animation of collapse opening
2 participants