fix: get container after Workbench is mounted #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wewoor
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
+ Coverage 91.05% 91.06% +0.01%
==========================================
Files 188 188
Lines 6071 6078 +7
Branches 1476 1476
==========================================
+ Hits 5528 5535 +7
Misses 537 537
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
wewoor
force-pushed
the
fix/quickAccessPosition
branch
from
5f13ec2 to
b89a631
Compare
wewoor
added a commit
that referenced
this pull request
Apr 3, 2023
* feat: support onWorkbenchDidMount event * test: unit test for onWorkbenchDidMount event * fix: initWorkspace after workbench did mount * feat: add EmbeddedWorkbench example * fix: rename standalone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the initial logic of
monacoService. the initWorkspace method depends on thecontainerproperty oflayoutService, but thecontainershould be set after theWorkbenchcomponent is mounted.Fixes #846
Changes
layoutServicesupports onWorkbenchDidMount event