#6 Fix broken converters

Daguerreo · Nov 10, 2021 · cde13a5 · cde13a5
1 parent e0801c1
commit cde13a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/include/nodes/internal/Connection.hpp b/include/nodes/internal/Connection.hpp
@@ -115,7 +115,7 @@ class NODE_EDITOR_PUBLIC Connection
   NodeDataType
   dataType(PortType portType) const;
 
-  TypeConverter getTypeConverter() const;
+  TypeConverter& typeConverter();
 
   void
   setTypeConverter(TypeConverter converter);

diff --git a/src/Connection.cpp b/src/Connection.cpp
@@ -420,9 +420,7 @@ dataType(PortType portType) const
   Q_UNREACHABLE();
 }
 
-TypeConverter
-Connection::
-getTypeConverter() const
+QtNodes::TypeConverter& Connection::typeConverter()
 {
     return _converter;
 }

diff --git a/src/Node.cpp b/src/Node.cpp
@@ -198,7 +198,7 @@ propagateData(PortIndex inPortIndex) const
       Node* outNode = c->getNode(PortType::Out);
       PortIndex outNodeIndex = c->getPortIndex(PortType::Out);
       std::shared_ptr<NodeData> outData = outNode->nodeDataModel()->outData(outNodeIndex);
-      TypeConverter converter = c->getTypeConverter();
+      auto& converter = c->typeConverter();
       if (converter != nullptr)
       {
         outData = converter(outData);