Skip to content

Commit

Permalink
Fixing calendarForSaving error - Related to #119
Browse files Browse the repository at this point in the history
  • Loading branch information
DamascenoRafael committed Jul 1, 2023
1 parent 2d7d6f0 commit 463be2d
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions reminders-menubar/Views/FormNewReminderView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ struct FormNewReminderView: View {
@State var isShowingDueDateOptions = false

var body: some View {
let calendarForSaving = rmbReminder.textCalendarResult.calendar ?? remindersData.calendarForSaving
let calendarForSaving = getCalendarForSaving()
// swiftlint:disable:next redundant_discardable_let
let _ = CalendarParser.updateShared(with: remindersData.calendars)

Form {
HStack(alignment: .top) {
newReminderTextFieldView(onSubmit: { createNewReminder(in: calendarForSaving) })
newReminderTextFieldView()
.padding(.vertical, 8)
.padding(.horizontal, 8)
.padding(.leading, 22)
Expand Down Expand Up @@ -93,14 +93,14 @@ struct FormNewReminderView: View {
}

@ViewBuilder
func newReminderTextFieldView(onSubmit: @escaping () -> Void) -> some View {
func newReminderTextFieldView() -> some View {
VStack(alignment: .leading) {
RmbHighlightedTextField(placeholder: rmbLocalized(.newReminderTextFielPlaceholder),
text: $rmbReminder.title,
highlightedTexts: rmbReminder.highlightedTexts,
isInitialCharValidToAutoComplete: CalendarParser.isInitialCharValid(_:),
autoCompleteSuggestions: CalendarParser.autoCompleteSuggestions(_:),
onSubmit: onSubmit)
onSubmit: createNewReminder)
.modifier(FocusOnReceive(userPreferences.$remindersMenuBarOpeningEvent))

if isShowingDueDateOptions {
Expand All @@ -117,10 +117,14 @@ struct FormNewReminderView: View {
return rmbReminder
}

private func createNewReminder(in calendarForSaving: EKCalendar?) {
private func getCalendarForSaving() -> EKCalendar? {
return rmbReminder.textCalendarResult.calendar ?? remindersData.calendarForSaving
}

private func createNewReminder() {
let newReminderTitle = finalNewReminderTitle()
guard !newReminderTitle.isEmpty,
let calendarForSaving else {
let calendarForSaving = getCalendarForSaving() else {
return
}

Expand Down

0 comments on commit 463be2d

Please sign in to comment.