Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: make the date preview under the reminder title localisable #150

Closed
katullo11 opened this issue Jul 3, 2023 · 9 comments
Closed

Comments

@katullo11
Copy link
Contributor

As of now, the date under the reminder title doesn't pick up the language chosen for the app, it is always English.

@DamascenoRafael
Copy link
Owner

Thanks for the feedback. Trying to understand how this can be fixed.

@DamascenoRafael
Copy link
Owner

@katullo11 just to confirm, you are referring to the date showed when creating a reminder, as highlighted in the image below, right? I think I found a fix for this, I'm running some tests.

image

@katullo11
Copy link
Contributor Author

@DamascenoRafael yes, but I'm also referring to when the reminder has already been created. The date under its name will always be in English.

@DamascenoRafael
Copy link
Owner

@katullo11 I believe that the date for created reminders is already appearing according to the language selected in the App. What happens is that after changing the language it may be necessary to close and reopen the app or at least hover the mouse over the elements so that the text is updated. Examples below for System (en), Portuguese and Dutch. Let me know if there is any behavior in this regard that does not seem correct.

  • system (English)
    Screenshot 2023-09-27 at 21 03 31

  • Portuguese
    Screenshot 2023-09-27 at 21 04 23

  • Dutch
    Screenshot 2023-09-27 at 21 05 27

@katullo11
Copy link
Contributor Author

katullo11 commented Sep 28, 2023

@DamascenoRafael I have tried restarting and hovering, but the language stays in English even though I have set Italian as my primary system language. If I set the app's language to Italian, the dates do show correctly, so it may be related to an incorrect interpretation of the system language?

This is my system language configuration:
87737

This is the app's behaviour with "System language" set:
33120

@DamascenoRafael
Copy link
Owner

@katullo11 to confirm, if you select Italian as your preferred language (and then close and reopen the app), can you see the dates as below?

Screenshot 2023-09-28 at 23 50 55

From what I understand, the problem would only be when selecting the "Use system language" option, right?

@katullo11
Copy link
Contributor Author

@DamascenoRafael exactly. The problem only persists as long as I have "System Language" set.

@DamascenoRafael
Copy link
Owner

@katullo11, sorry, I know it's been a while. I think this is possibly fixed in version 1.22.0, could you please try it?

@katullo11
Copy link
Contributor Author

No need to apologise. It seems to be fixed now! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants