-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.12.0 - App crashes #95
Comments
Thank you for reporting this @LocheBC. Can you tell me what version of macOS you are using? And just to confirm, v1.11.0 works fine, right? |
Yes, no problem with V1.11.0!
I’m on macOS Ventura 13.2 (a) Beta - Build 22D7750270d
… On Jan 4, 2023, at 1:31 PM, Rafael Damasceno ***@***.***> wrote:
Thank you for reporting this @LocheBC <https://github.com/LocheBC>.
I'll try to check it later today.
Can you tell me what version of macOS you are using?
And just to confirm, v1.11.0 works fine, right?
—
Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4XQFVJZQK7KV6E7RYFJA4DWQXT4HANCNFSM6AAAAAATRHHTZE>.
You are receiving this because you were mentioned.
|
hey @LocheBC. I'm wondering if it might be some problem happening only in macOS beta. Do you think you could download the project and try to run it in Xcode? That way Xcode will possibly point out where it is crashing. Another option would be to see the log which should be saved in ~/Library/Logs/DiagnosticReports/, the file name should start with "Reminders Menu Bar". To open 'Library', open Finder and hold down the Option key before clicking the 'Go' menu in Finder's menu bar. |
Hi Rafael,
Here’s the log from the first time I ran V1.12.0
I don’t have XCode anymore, but I could redownload it if you can’t do anything with the log file.
Thanks for your work.

… On Jan 4, 2023, at 7:38 PM, Rafael Damasceno ***@***.***> wrote:
hey @LocheBC <https://github.com/LocheBC>.
I talked to a friend running macOS 13.0.1 on an M1 and he had no issues.
Same thing for me running macOS 13.1 on an Intel i7 MBP.
I'm wondering if it might be some problem happening only in macOS beta.
Do you think you could download the project and try to run it in Xcode? That way Xcode will possibly point out where it is crashing.
Another option would be to see the log which should be saved in ~/Library/Logs/DiagnosticReports/, the file name should start with "Reminders Menu Bar". To open 'Library', open Finder and hold down the Option key before clicking the 'Go' menu in Finder's menu bar.
—
Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4XQFVOCK6ND4D53WKSBORTWQY62DANCNFSM6AAAAAATRHHTZE>.
You are receiving this because you were mentioned.
|
I think the file was not attached, can you check? If you prefer you can send me the log by DM on twitter. |
Reminders Menu Bar-2023-01-04-115523.ips.zip Oh sorry, apparently GitHub doesn't support IPS files. Here's a zipped version. |
I'm running macOS 13.1 and experienced the same thing with the latest release (1.12.0). I believe the problem occurs only if you haven't given access to Reminders. Then trying to instantiate an Here's the exception:
|
@peteschaffner thanks, I guess you're right. This could be the cause of the problem because in v1.12.0 I initialize the UserPreferences due to the custom icon before having the permission. I will release a fix for this! |
@LocheBC @peteschaffner |
@DamascenoRafael No it didn't fix the issue for me. I tried disabling the permission to access Reminders. Then, when I open V1.12.1, it prompts me to enable access. But then it crashes again. I'll try to download XCode tonight. |
@LocheBC It makes sense that you're having a different issue because you already gave permission in a previous version of the app. Please let me know if you run the app in Xcode as it will probably show an exception somewhere. I'm still not sure what could be happening. |
Both the distributed binary (turning off the existing Reminders permission in System Settings) and running in Xcode worked for me 👍 |
Apologies for the delay. I finally ran V1.12.1 with Xcode. Errors I get are all related to "Publishing changes from within view updates is not allowed, this will cause undefined behavior." Not sure if there's a better way to share the error log, but here's a screenshot: |
I just upgraded to MacOS Ventura 13.2 Beta 2 and I still have the same issue with V1.12.0/1. V1.11.0 still works fine. |
hey @LocheBC, I'm still trying to understand what could be causing this issue. About the screenshot you sent, did the purple warnings appear as soon as you clicked on the icon in the menu bar and then it crashed? In addition to these alerts, did no other appear? |
Correct, the purple warnings appear as soon as I click on the menu bar icon and then it crashes. No other alerts, just multiple of this same "Publishing changes from within view updates is not allowed, this will cause undefined behavior." Yes, I'm using Xcode 14.2 (14C18). EDIT: Also note that my screenshot shows both V1.11.0 running at the same time as V1.12.1 (through Xcode). I tested afterwards running just V1.12.1 and closed V1.11.0, but got the same crash report. Let me know if I can help in any way. |
@LocheBC Still can't figure out why it's crashing for you, but it must have been some change between v1.11.0 and v1.12.0. To try and narrow down what might be causing this can you please try the below changes in Xcode one at a time and see if that stops it from crashing?
func loadMenuBarIcon() {
- let menuBarIcon = UserPreferences.instance.reminderMenuBarIcon
- statusBarItem.button?.image = menuBarIcon.image
+ statusBarItem.button?.image = NSImage(systemSymbolName: "list.bullet", accessibilityDescription: nil)
}
// NOTE: This is a workaround to access the URL saved in a reminder.
// This property is not accessible through the conventional API.
var attachedUrl: URL? {
+ return nil
let backingObjectSelector = NSSelectorFromString("backingObject")
let reminderSelector = NSSelectorFromString("_reminder")
let attachmentsSelector = NSSelectorFromString("attachments")
if let unmanagedBackingObject = self.perform(backingObjectSelector),
let unmanagedReminder = unmanagedBackingObject.takeUnretainedValue().perform(reminderSelector),
let unmanagedAttachments = unmanagedReminder.takeUnretainedValue().perform(attachmentsSelector),
let attachments = unmanagedAttachments.takeUnretainedValue() as? [AnyObject] {
for item in attachments {
guard let unmanagedUrl = item.perform(NSSelectorFromString("url")),
let url = unmanagedUrl.takeUnretainedValue() as? URL else {
continue
}
return url
}
}
return nil
} |
@LocheBC Let me know if you have the opportunity to try this out. |
I got the same issue (similar exception in log) and the second method fixed it for me. MacBook Pro (16-inch, 2019, intel) / MacBookPro16,1 |
Hey @DamascenoRafael, Sorry or the delay. As @receyuki pointed out, the second change "fixed" it. But then obviously I couldn't access the URL tags. So I investigated further and figured out the issue. I have reminders that have both an URL tag and an image associated to it. Thus, it has more than one attachment. Your workaround for the lack of URL API from Apple does not seem to handle multiple attachments. As soon as I deleted all the images in my Reminders, V1.12.1 would run just fine. Now, I'm not good enough at coding to know how to handle the image attachments as well. EDIT: To be clear, I personally don't need Reminders Menu Bar to display the images associated with a reminder. It just need to ignore these images and not crash. Cheers! Laurent |
As soon as i removed every Image in my Reminders, it started working again. Props for figuring it out & a big thank you for the great app! |
@receyuki and @mittelgrau sorry to hear that you are also facing this issue. @LocheBC thank you for your investigation!! |
@LocheBC, @receyuki and @mittelgrau please try version 1.13.0 📦 |
Works for me! Thanks for your work @DamascenoRafael ! |
I installed V1.12.0 using the zip file (not Homebrew). The app crashes and quit as soon as I click on the menu bar icon.
Tried to reboot, didn't change anything.
I then tried to do a complete uninstall of V1.11.0 using AppCleaner. Reinstalled V1.12.0, then when I click the icon, it crashes but does not quit (icon gets darker but nothing shows up, unresponsive).
Returned to V1.11.0 for the moment, although I'm very much looking forward for the URL implementation.
I'm on a MBP 14" M1 - Base model.
Cheers
The text was updated successfully, but these errors were encountered: