Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Localization #117

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Conversation

Piaziker
Copy link
Contributor

@Piaziker Piaziker commented Mar 7, 2023

Here's the first attempt at a French Localization

@DamascenoRafael
Copy link
Owner

Thanks for your contribution @Piaziker 🎉

I don't understand French 🤣 , but could you double-check the translation for newReminderRemoveParsedDateOption?

More context on this:
This option will be presented as in the image below, and when enabled the date that the user entered as part of the title will be removed from the title when creating the new reminder.
So, for example, if the user types "do something tomorrow" as a new reminder, the app will automatically add the date referring to "tomorrow" and if the option is enabled, the new reminder will be created as "do something".

Screenshot 2023-03-06 at 20 18 57

@Piaziker
Copy link
Contributor Author

Piaziker commented Mar 9, 2023

Ok, understood. I have reviewed and adjusted. I also did another pass to make sure the "completed" term was in line with Apple ("terminés" instead of "complétés")

@DamascenoRafael
Copy link
Owner

Great @Piaziker!
Sorry to bother you again about the translation for newReminderRemoveParsedDateOption.

Please let me know if this makes sense or if any adjustments are needed.

Using google translate (which could be completely wrong 😆) the French translation appears as:

"newReminderRemoveParsedDateOption" = "Do not detect date"; (Ne pas détecter la date)

whereas the original english text is:

"newReminderRemoveParsedDateOption" = "Remove parsed date from title";

About the option that this string represents, using the same example I gave earlier,
if the user types "do something tomorrow" the app behavior will be:

  • With the option enabled:
    The date referring to tomorrow will be suggested and the reminder will be saved as "do something".

  • With the option disabled:
    The date referring to tomorrow will be suggested and the reminder will be saved as "do something tomorrow".

In both cases the date is recognized and suggested, the only difference is whether the parsed/analyzed date will be removed from the title or not.

Thanks again for the contribution!

@Piaziker
Copy link
Contributor Author

I understand that. I made this choice because I couldn't arrive at something pleasant.
A literal translation would be "Retirer la date détectée dans le titre", which is convoluted. I'm trying something else

@DamascenoRafael
Copy link
Owner

Thanks for the changes and for the effort to add French as a supported language 👏
It's really not an easy thing to translate, I went through the same thing when translating into Brazilian Portuguese 😆

I'm accepting this PR now, and in the future if you find it necessary we can update some of the texts.

@DamascenoRafael DamascenoRafael merged commit 1c60415 into DamascenoRafael:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants