Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little change in Spanish localization #62

Merged
merged 11 commits into from
Sep 6, 2022
Merged

Little change in Spanish localization #62

merged 11 commits into from
Sep 6, 2022

Conversation

zydeico
Copy link
Contributor

@zydeico zydeico commented Sep 2, 2022

No description provided.

zydeico and others added 10 commits August 24, 2022 23:15
Co-authored-by: Rafael Damasceno <DamascenoRafael@users.noreply.github.com>
Co-authored-by: Rafael Damasceno <DamascenoRafael@users.noreply.github.com>
Co-authored-by: Rafael Damasceno <DamascenoRafael@users.noreply.github.com>
Co-authored-by: Rafael Damasceno <DamascenoRafael@users.noreply.github.com>
Co-authored-by: Rafael Damasceno <DamascenoRafael@users.noreply.github.com>
@DamascenoRafael
Copy link
Owner

Thanks for your contribution! 🎉

I'm definitely not fluent in Spanish, but is this the way other apps commonly present these texts in Spanish? If so, I see no problem in approving the changes 😃
I say this because I think that some translations are not exactly the same between English and Spanish (like launchAtLoginOptionButton), but I believe they have the same meaning.

Another small detail, es-419 refers to "Spanish (Latin America)", as this covers different countries do you think it would be better to use the flag of Spain 🇪🇸 ? Let me know what you think and if it would be appropriate.

Thanks again for taking the time to make this a better app!

@zydeico
Copy link
Contributor Author

zydeico commented Sep 4, 2022

Hey! Thanks for review this changes.
Well, this translations changes are based in other apps and Spanish sounds better, I'm from Mexico and this is the better way to present text (Spanish Spain is a little different in some words)

@DamascenoRafael
Copy link
Owner

Great! We can approve the translation changes 😄

For Brazil there is also a bit of confusion with Portuguese (Brazil) and Portuguese (Portugal), hahaha.

Regarding the flag we can keep it that way and in the future if there are new additions to Spanish we can think about how to present it. Can you change it to "Spanish (Latin America)" just to be clearer?

@zydeico
Copy link
Contributor Author

zydeico commented Sep 6, 2022

hahaha no problem, for Brazil you're right, they need Portuguese language and is a little different of Spanish.

Sure, I add the change right now 😄

@DamascenoRafael DamascenoRafael merged commit 012099d into DamascenoRafael:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants