Update Reader.php to include filter by user #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienHarper
approved these changes
Jul 7, 2024
DamienHarper
requested changes
Jul 14, 2024
There was a problem hiding this comment.
Thanks @RomanApunts, could you please add some tests so that I can safely merge this PR?
|
Right now i have no time to do it, maybe in some weeks i can do it…
Sorry
De: Damien Harper ***@***.***
Enviado el: domingo, 14 de julio de 2024 14:31
Para: DamienHarper/auditor ***@***.***>
CC: RomanApunts ***@***.***>; Mention ***@***.***>
Asunto: Re: [DamienHarper/auditor] Update Reader.php to include filter by user (PR #205)
@DamienHarper requested changes on this pull request.
Thanks @RomanApunts <https://github.com/RomanApunts> , could you please add some tests so that I can safely merge this PR?
—
Reply to this email directly, view it on GitHub <#205 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO7YDL7TJENR7GOXO5IB2UTZMJVP7AVCNFSM6AAAAABKI4H6MWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZWGY2DKMJWGA> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
DamienHarper
approved these changes
Sep 4, 2024
DamienHarper
added a commit
that referenced
this pull request
Sep 4, 2024
…ep consistency with real field name We can now query both by `blame_id` or `user_id`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.